Clean up native code #1389
Merged
Clean up native code #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
cb-jake
reviewed
Sep 10, 2024
| @@ -28,7 +28,7 @@ export class CoinbaseWalletProvider extends ProviderEventEmitter implements Prov | |||
| super(); | |||
| this.metadata = metadata; | |||
| this.preference = preference; | |||
| this.communicator = Communicator.getInstance(keysUrl, metadata); | |||
| this.communicator = new Communicator(keysUrl, metadata); | |||
|
|
|||
| // Async initialize | |||
| this.initPromise = this.initialize(); | |||
There was a problem hiding this comment.
was this initialize part of the mobile work?
cb-jake
reviewed
Sep 10, 2024
| // default values | ||
| this.accounts = []; | ||
| this.chain = { | ||
| this.storage = new ScopedLocalStorage('CBWSDK', 'SCWStateManager'); |
There was a problem hiding this comment.
this.storage is defined twice here. L48 and L50
fan-zhang-sv
requested review from
cb-jake,
bangtoven,
vishnumad and
nateReiners
bangtoven
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We moved native code to a different repo, removing them here
How did you test your changes?