Auto deploy playground to provide latest SDK implementation #1398

bangtoven · 2024-09-16T21:47:35Z

Summary

Bring back playground
Update CI to auto deploy playground with latest SDK version
https://github.com/coinbase/coinbase-wallet-sdk/pull/1398/files#r1764020280

How did you test your changes?

test deploy succeeded
https://github.com/coinbase/coinbase-wallet-sdk/actions/runs/10911132262

This reverts commit f74ba03. # Conflicts: # package.json # yarn.lock

cb-heimdall · 2024-09-16T21:47:37Z

✅ Heimdall Review Status

Requirement Status More Info

Reviews

✅ 1/1

Denominator calculation

Show calculation

1 if user is bot 0

1 if user is external 0

From .codeflow.yml 1

Additional review requirements

Show calculation

Max	0

0

From CODEOWNERS 0

Global minimum 0

Max 1

1

1 if commit is unverified 0

Sum 1

* delete non pg code * Separate branch for playground * cleanup * yarn export * fix package.json * fix ci * ci. no unit test on pg * fix * update testapp to 4.0.1 (#1300) * 4.0.2 --------- Co-authored-by: Nate <nate.reiners@coinbase.com> Separate branch for playground (#1304) * delete non pg code * Separate branch for playground * cleanup * yarn export * fix package.json * fix ci * ci. no unit test on pg * fix * update testapp to 4.0.1 (#1300) * 4.0.2 --------- Co-authored-by: Nate <nate.reiners@coinbase.com>

* Use viem to verify 6492 signed messages * Keep track of the switch chain state to make the verify message functionality more robust * Fix whitespace * Set chain id based on current provider state * Fix npe when using extension

bangtoven · 2024-09-16T23:41:36Z

.github/workflows/build-and-deploy.yml

@@ -17,26 +17,29 @@ concurrency:
 jobs:


build job has been verified
depoly is expected to fail due to branch restriction.

https://github.com/coinbase/coinbase-wallet-sdk/actions/runs/10893719985

import HEAD

cb-jake · 2024-09-17T19:18:42Z

package.json

@@ -0,0 +1,29 @@
+{


The dev script doesn't seem to be working. Its starting the sdk but not the playground

bangtoven · 2024-09-17T20:58:19Z

.yarnrc.yml

+  - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
+    spec: "@yarnpkg/plugin-interactive-tools"
+
+yarnPath: .yarn/releases/yarn-3.6.1.cjs


bring back previous yarn setup #1069
ty @cb-jake

bangtoven · 2024-09-17T21:03:37Z

packages/wallet-sdk/jest.setup.ts

-        this.utils.printDiffOrStringify(expected, received, 'Expected', 'Received', true),
-    };
-  },
-});


this custom helper started causing some tsc typecheck bugs with newer yarn version for some reason.
deprecating and replacing with standard toMatchObject

bangtoven · 2024-09-17T21:04:19Z

packages/wallet-sdk/package.json

@@ -53,6 +53,7 @@
    "eslint-plugin-prettier": "^5.0.0",
    "eslint-plugin-simple-import-sort": "^10.0.0",
    "eslint-plugin-unused-imports": "^3.0.0",
+    "glob": "^11.0.0",


adding it as dev dep. yarn 3.6 complains this is not found otherwise

Maybe in a future PR we can work on upgrading to yarn 4+. Not critical for now

bangtoven · 2024-09-17T21:09:58Z

yarn.lock

+"@coinbase/wallet-sdk-4.0.4@npm:@coinbase/wallet-sdk@latest":
+  version: 4.0.4
+  resolution: "@coinbase/wallet-sdk@npm:4.0.4"
+  dependencies:
+    buffer: "npm:^6.0.3"
+    clsx: "npm:^1.2.1"
+    eventemitter3: "npm:^5.0.1"
+    keccak: "npm:^3.0.3"
+    preact: "npm:^10.16.0"
+    sha.js: "npm:^2.4.11"
+  checksum: 002d03d791683a15b465a285d7293a7994684f6f91d67c01b52ee9a07ba62f555a12d5c9471c964ccae0df048190f9c2e82929aeba9247e6d97ad1a9e9dd4132
+  languageName: node
+  linkType: hard
+
+"@coinbase/wallet-sdk@workspace:*, @coinbase/wallet-sdk@workspace:packages/wallet-sdk":
+  version: 0.0.0-use.local
+  resolution: "@coinbase/wallet-sdk@workspace:packages/wallet-sdk"


importing the latest npm published version and local workspace version

cb-jake

Awesome work @jungho! The dev script is working again. Tested making changes locally and the playground is picking them up in real time!

bangtoven · 2024-09-17T21:26:21Z

thanks for your help and guidance @cb-jake 🙇

Revert "Remove playground from master branch (#1305)"

ce94683

This reverts commit f74ba03. # Conflicts: # package.json # yarn.lock

bangtoven force-pushed the jungho/revive-playground branch 3 times, most recently from aad4010 to 62f642d Compare September 16, 2024 22:22

bangtoven and others added 5 commits September 16, 2024 15:23

bump playground to 4.0.3 (#1312)

8e4cc07

bump playground to 4.0.4 (#1330)

8014123

6492 verify message (#1382)

7d2e9c2

* Use viem to verify 6492 signed messages * Keep track of the switch chain state to make the verify message functionality more robust * Fix whitespace * Set chain id based on current provider state * Fix npe when using extension

lint (#1384)

c37ac19

bangtoven force-pushed the jungho/revive-playground branch 6 times, most recently from c5882c1 to e2e32db Compare September 16, 2024 23:22

reorg

545d834

bangtoven force-pushed the jungho/revive-playground branch 2 times, most recently from 63ad60c to 7ecdea9 Compare September 16, 2024 23:34

bangtoven had a problem deploying to github-pages September 16, 2024 23:35 — with GitHub Actions Failure

bangtoven commented Sep 16, 2024

View reviewed changes

bangtoven force-pushed the jungho/revive-playground branch 6 times, most recently from 7dcb354 to 445214f Compare September 17, 2024 01:01

bangtoven temporarily deployed to github-pages September 17, 2024 01:06 — with GitHub Actions Inactive

bangtoven force-pushed the jungho/revive-playground branch from 445214f to 48be703 Compare September 17, 2024 01:08

deploy script

35ee03e

import HEAD

moved to apps/playground

c318013

cb-jake reviewed Sep 17, 2024

View reviewed changes

bangtoven added 6 commits September 17, 2024 12:40

yarn set version stable

37a7f5f

import local and npm latest

0519c47

let’s see

90e6bf7

yarn 4.5.0

e8d0446

update

8262e57

hmmmmm

627e169

bangtoven marked this pull request as draft September 17, 2024 20:28

bangtoven added 4 commits September 17, 2024 13:32

hmmmm

7fa1a1e

asdf

e253d6f

deploy

ea5a805

remove redundant jest helper

d6d83f7

bangtoven commented Sep 17, 2024

View reviewed changes

bangtoven force-pushed the jungho/revive-playground branch from 014a95d to 2ada27e Compare September 17, 2024 21:05

min diff

4d332ba

bangtoven force-pushed the jungho/revive-playground branch from 2ada27e to 4d332ba Compare September 17, 2024 21:06

bangtoven commented Sep 17, 2024

View reviewed changes

bangtoven marked this pull request as ready for review September 17, 2024 21:11

bangtoven temporarily deployed to github-pages September 17, 2024 21:11 — with GitHub Actions Inactive

bangtoven requested review from cb-jake, fan-zhang-sv and eric-ships September 17, 2024 21:12

cb-jake reviewed Sep 17, 2024

View reviewed changes

cb-jake approved these changes Sep 17, 2024

View reviewed changes

bangtoven merged commit 7dd339a into master Sep 17, 2024
10 checks passed

bangtoven deleted the jungho/revive-playground branch September 17, 2024 21:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto deploy playground to provide latest SDK implementation #1398

Auto deploy playground to provide latest SDK implementation #1398

bangtoven commented Sep 16, 2024 •

edited

Loading

cb-heimdall commented Sep 16, 2024 •

edited

Loading

bangtoven Sep 16, 2024

bangtoven Sep 16, 2024

cb-jake Sep 17, 2024

bangtoven Sep 17, 2024

bangtoven Sep 17, 2024

bangtoven Sep 17, 2024

bangtoven Sep 17, 2024

cb-jake Sep 17, 2024

bangtoven Sep 17, 2024

cb-jake left a comment

bangtoven commented Sep 17, 2024

Auto deploy playground to provide latest SDK implementation #1398

Auto deploy playground to provide latest SDK implementation #1398

Conversation

bangtoven commented Sep 16, 2024 • edited Loading

Summary

How did you test your changes?

cb-heimdall commented Sep 16, 2024 • edited Loading

✅ Heimdall Review Status

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cb-jake left a comment

Choose a reason for hiding this comment

bangtoven commented Sep 17, 2024

bangtoven commented Sep 16, 2024 •

edited

Loading

cb-heimdall commented Sep 16, 2024 •

edited

Loading