Fix chainChanged event emitting for walletlink connection #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
fan-zhang-sv
approved these changes
Sep 27, 2024
cb-jake
approved these changes
Sep 27, 2024
nateReiners
deleted the
nate/WALL-42689/walletlinkChainChangedEventFix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug where the first 'chainChanged' was not being emitted because no emitter callback was being passed to the WalletLinkSigner created by
listenForWalletLinkSessionRequestHow did you test your changes?
Locally
Here's a video showing the bug in 4.1.0 and this fix in HEAD
https://github.com/user-attachments/assets/e762a9d1-69f1-4124-a844-cf0dc346e9df