Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: project module resolution #1428

Merged
merged 11 commits into from
Oct 17, 2024
Merged

fix: project module resolution #1428

merged 11 commits into from
Oct 17, 2024

Conversation

cb-jake
Copy link
Contributor

@cb-jake cb-jake commented Oct 15, 2024 •
edited
Loading

Summary

Updates this PR to get into a state that can be merged.

How did you test your changes?

Manually

  • Run a build
  • Use the sdk playground

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 15, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-jake cb-jake changed the title Fix up pr fix: project module resolution Oct 17, 2024
@cb-jake cb-jake mentioned this pull request Oct 17, 2024
Closed
@fan-zhang-sv fan-zhang-sv merged commit bb531e3 into master Oct 17, 2024
8 checks passed
@fan-zhang-sv fan-zhang-sv deleted the jake/merge-jxom branch October 17, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fan-zhang-sv fan-zhang-sv fan-zhang-sv approved these changes

@spencerstock spencerstock Awaiting requested review from spencerstock

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cb-jake @cb-heimdall @fan-zhang-sv @jxom