Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sdk to pass location in postmessage #1443

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

cb-jake
Copy link
Contributor

@cb-jake cb-jake commented Nov 6, 2024

Summary

When connecting to the dapp browser with linkdrop pathname and query params did not persist. This includes the full location for keysdot to process

How did you test your changes?

  1. Start keysdot (See corresponding PR on keys side) and sdk playground.
  2. Set the keys url to localhost
  3. Using the sim (needs cbw mobile on it) or ngrok with actual device, open the playground in a browser window. (add some random query params)
  4. Open the onboarding flow and select mobile. This should open in the dapp browser. Verify the query params persist.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 6, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@arjun-dureja arjun-dureja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cb-jake cb-jake merged commit a696e53 into master Nov 6, 2024
8 checks passed
@cb-jake cb-jake deleted the include-location branch November 6, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants