Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move vitest to devDependencies #1447

Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore: move vitest to devDependencies #1447

merged 1 commit into from
Nov 11, 2024

Conversation

tmm
Copy link
Contributor

@tmm tmm commented Nov 9, 2024 •
edited
Loading

Summary

Vitest should be a dev dependency.

How did you test your changes?

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 9, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for cb-jake @ 2024-11-11 16:15:09 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@cb-jake cb-jake merged commit 924c758 into coinbase:master Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb-jake cb-jake cb-jake approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmm @cb-heimdall @cb-jake