Fix 4902 (unsupportedChain) error getting wrapped as -32603 & Fork eth-rpc-errors #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangtoven
changed the title
cb-jake
reviewed
Jul 27, 2023
cb-jake
reviewed
Jul 27, 2023
| serialized.data = { originalError: assignOriginalError(error) }; | ||
| } | ||
|
|
||
| const stack = (error as any)?.stack; |
There was a problem hiding this comment.
We should follow the same pattern here
There was a problem hiding this comment.
We could make this generic and use it for both cases
function hasProperty(obj: unknown, prop: string): obj is {stack: string} {
return typeof obj === 'object' && obj !== null && prop in obj;
}
const stack = hasProperty(error, 'stack') ? error.stack : undefined
bangtoven
commented
Jul 27, 2023
cb-jake
approved these changes
Jul 28, 2023
bangtoven
added a commit
that referenced
this pull request
Oct 20, 2023
…h-rpc-errors (#954) # Conflicts: # packages/wallet-sdk/package.json # packages/wallet-sdk/src/errors.ts # packages/wallet-sdk/src/errors/serialize.test.ts # yarn.lock
bangtoven
added a commit
that referenced
this pull request
Feb 29, 2024
bangtoven
added a commit
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test your changes?