Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable validation file for other commands #239

Merged
merged 1 commit into from
Sep 8, 2021
Merged

enable validation file for other commands #239

merged 1 commit into from
Sep 8, 2021

Conversation

shrimalmadhur
Copy link
Contributor

Fixes # .

Motivation

We want to enable validation file use for other commands.

Solution

Added validation config to the other command asserter intialization.

Open questions

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7114

  • 0 of 3 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 42.259%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/check_data.go 0 1 0.0%
cmd/view_balance.go 0 1 0.0%
cmd/view_block.go 0 1 0.0%
Totals Coverage Status
Change from base Build 7090: 0.0%
Covered Lines: 707
Relevant Lines: 1673
💛 - Coveralls

xiaying-peng
xiaying-peng approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@xiaying-peng xiaying-peng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrimalmadhur shrimalmadhur merged commit 5192235 into master Sep 8, 2021
@shrimalmadhur shrimalmadhur deleted the madhur/enable-data branch September 8, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaying-peng xiaying-peng xiaying-peng approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrimalmadhur @coveralls @xiaying-peng