Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for zap logger for structured logs #276

Merged
merged 4 commits into from
Feb 24, 2022
Merged

add support for zap logger for structured logs #276

merged 4 commits into from
Feb 24, 2022

Conversation

shrimalmadhur
Copy link
Contributor

@shrimalmadhur shrimalmadhur commented Feb 23, 2022 •
edited
Loading

Fixes #59 .

Motivation

We don't have a structured logging framework in rosetta-cli

Solution

  • Add structured logging via Zap Logger
  • Expose basic methods in overall loggers
    • Example: we can use logger.Info directly and it will make sure to log in a structured way

Screen Shot 2022-02-23 at 1 13 37 PM

Open questions

@coveralls
Copy link

coveralls commented Feb 23, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 7581

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.958%
Totals Coverage Status
Change from base Build 7552: 0.0%
Covered Lines: 707
Relevant Lines: 1685
💛 - Coveralls

@shrimalmadhur shrimalmadhur changed the title [wip] add zap logger add support for zap logger for structured logs Feb 23, 2022
@cb-heimdall
Copy link

Review Error for raghavapamula @ 2022-02-23 23:28:30 UTC
User must have write permissions to review

@shrimalmadhur shrimalmadhur merged commit d7d68de into master Feb 24, 2022
@shrimalmadhur shrimalmadhur deleted the madhur/zap-logger branch February 24, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavapamula raghavapamula raghavapamula approved these changes

@xiaying-peng xiaying-peng xiaying-peng approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structured Logging
5 participants
@shrimalmadhur @coveralls @cb-heimdall @raghavapamula @xiaying-peng