Make status port configurable via command line args #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingweicb
reviewed
Dec 12, 2022
cmd/root.go
Outdated
| @@ -58,6 +58,7 @@ var ( | |||
| inMemoryMode bool | |||
| tableSize int64 | |||
| requestUUID string | |||
| statusPort uint | |||
There was a problem hiding this comment.
the space is too much...
There was a problem hiding this comment.
I think this is github UI issue
jingweicb
previously approved these changes
Dec 12, 2022
cb-heimdall
dismissed
jingweicb’s stale review
Approved review 1214447835 from jingweicb is now dismissed due to new commit. Re-request for approval.
jingweicb
previously approved these changes
Dec 12, 2022
shrimalmadhur
previously approved these changes
Dec 12, 2022
cb-heimdall
dismissed stale reviews from shrimalmadhur and jingweicb
Approved review 1214454464 from shrimalmadhur is now dismissed due to new commit. Re-request for approval.
shrimalmadhur
approved these changes
Dec 12, 2022
jingweicb
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
We need to make status port configurable via command line, so we can run multiple rosetta-cli with status server enabled in same host.
Solution
Support command line args in root.go
Tested with
Open questions