Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Return Funds Workflow #158

Merged
merged 2 commits into from
Sep 16, 2020
Merged

[BUG] Return Funds Workflow #158

merged 2 commits into from
Sep 16, 2020

Conversation

patrick-ogrady
Copy link
Contributor

This PR fixes a small bug introduced #156 where we may attempt to create any workflow when calling ReturnFunds.

Changes

  • return immediately if no returns flow exists
  • log when beginning and ending return funds
  • ensure we only attempt return_funds while returning funds

@patrick-ogrady patrick-ogrady merged commit a810778 into master Sep 16, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/return-funds-fix branch September 16, 2020 00:35
@patrick-ogrady patrick-ogrady mentioned this pull request Sep 16, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfl92 yfl92 yfl92 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrick-ogrady @yfl92