Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parser Package #21

Merged
merged 6 commits into from
May 8, 2020
Merged

Add Parser Package #21

merged 6 commits into from
May 8, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented May 8, 2020

Motivation

When parsing operations in a block, it is difficult to group related operations and calculate all balance changes.

Solution

Create parser package that provides support for parsing the balance changes in a block and for grouping related operations.

Bug Fixes

  • Remove need to use GO111MODULE=off in Makefile
  • Allow Currency with Decimals=0
  • Fix panic in BalanceChanges when operation.Amount=nil

Future PR

  • Remove balance changes logic from rosetta-cli

@coveralls
Copy link

coveralls commented May 8, 2020

Pull Request Test Coverage Report for Build 1008

  • 147 of 166 (88.55%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 86.513%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/balance_changes.go 56 65 86.15%
parser/group_operations.go 42 52 80.77%
Totals Coverage Status
Change from base Build 919: 0.7%
Covered Lines: 789
Relevant Lines: 912

💛 - Coveralls

@patrick-ogrady patrick-ogrady changed the title [WIP] Parser Add Parser Package May 8, 2020
@patrick-ogrady patrick-ogrady merged commit ae7905f into master May 8, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/parser branch May 8, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants