Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort OperationGroup Results #24

Merged
merged 3 commits into from
May 12, 2020
Merged

Sort OperationGroup Results #24

merged 3 commits into from
May 12, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented May 12, 2020 •
edited
Loading

Motivation

It can be very useful for clients to receive a deterministic ordering of OperationGroups and Operations within an OperationGroup when calling GroupOperations.

Solution

Sort all OperationGroups in a transaction by the lowest OperationIdentifier.Index in each group. Then, sort all Operations in an OperationGroup by OperationIdentifier.Index, ascending.

@coveralls
Copy link

coveralls commented May 12, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1088

  • 27 of 27 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 87.039%
Totals Coverage Status
Change from base Build 1057: 0.3%
Covered Lines: 826
Relevant Lines: 949
💛 - Coveralls

annieke
annieke previously approved these changes May 12, 2020
View reviewed changes
@patrick-ogrady patrick-ogrady merged commit 6d666d5 into master May 12, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/sorted-results branch May 12, 2020 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annieke annieke annieke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrick-ogrady @coveralls @annieke