Migrate Syncer and Reconciler Packages #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
force-pushed
the
patrick/syncer-reconciler-packages
branch
from
c7ca2ff
to
5148cef
Compare
Pull Request Test Coverage Report for Build 1145
💛 - Coveralls |
patrick-ogrady
force-pushed
the
patrick/syncer-reconciler-packages
branch
from
5148cef
to
76e4df0
Compare
annieke
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
rosetta-cliimplements syncing and reconciliation logic but it is not useful to any other packages because it is in an/internal.Solution
Migrate the
syncerandreconcilerpackage torosetta-cli. This makes it easy for anyone to use this functionality. This PR does not introduce any major changes to the code that was inrosetta-cli.Links
rosetta-cliremoval: coinbase/mesh-cli#18Future PR
Improve coverage in
syncerandreconciler