Add validation for negative fee amount #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err != nil { | ||
| return err | ||
| } | ||
| if val.Sign() != -1 { |
There was a problem hiding this comment.
Let's add test coverage
| @@ -513,6 +521,52 @@ func TestOperationsValidations(t *testing.T) { | |||
| construction: false, | |||
| err: ErrRelatedOperationInFeeNotAllowed, | |||
| }, | |||
|
|
|||
| "fee amount is non-negative": { | |||
There was a problem hiding this comment.
this is the happy path, we want error case test as well
xiaying-peng
previously approved these changes
Apr 12, 2022
raghavapamula
force-pushed
the
add_validation_for_negative_fee_amount
branch
7 times, most recently
from
75dad3c
to
72fac48
Compare
raghavapamula
force-pushed
the
add_validation_for_negative_fee_amount
branch
from
72fac48
to
99d1fdf
Compare
xiaying-peng
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # https://jira.coinbase-corp.com/browse/ROSE-90
Motivation
Operations of type fee must have negative value
Solution
Add validation for this behaviour
Open questions