-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: isBase should be made less misleading #1167
Comments
Thank you @mykcryptodev, here a PR #1221 with The logic behind I agree with you it can feel a bit confusing, and we specified the scope of the utility in the docs. Happy to continue reflect on this in V1 if we see more adoption and confusion around this utility. |
Describe the solution you'd like
This may be a personal preference thing but to me, Base is 8453... if I want to use a helper to detect if something "isBase", it should only return true if the chain is 8453.
Currently, isBase will return true for Base Sepolia as well.
Perhaps for backwards compatibility, there should be optional parameters passed like:
Describe alternatives you've considered.
it's simple enough for me to make my own "isBaseMainnet" function:
but I feel like someone could stumble over "isBase" returning true for sepolia.
The text was updated successfully, but these errors were encountered: