chore: Update Wallet disconnect SVG #1103
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
changed the title
| @@ -6,16 +6,16 @@ export const disconnectSvg = ( | |||
| aria-label="ock-disconnect-svg" | |||
| width="100%" | |||
| height="100%" | |||
| viewBox="0 0 20 20" | |||
| viewBox="0 0 16 20" | |||
There was a problem hiding this comment.
Do we have a story for this component on Storybook?
There was a problem hiding this comment.
No, we do not have a storybook for any of our internal SVGs or our Wallet Components. Should I try to make one?
There was a problem hiding this comment.
I have a Fix Storybook task on Linear but it's getting deprioritized for tasks such as fix landing page and the upcoming Swap Component changes https://linear.app/coinbase/issue/BOE-313/fix-storybook
There was a problem hiding this comment.
My comment was more about. Go make a storybook page for every component you touch :)
So in this case you touch this component, let's have a story for this.
There was a problem hiding this comment.
TIL you can add a story for an SVG! Added!
cpcramer
force-pushed
the
paul/update-disconnect-icon
branch
from
9cdff76
to
44350c5
Compare
What changed? Why?
https://linear.app/coinbase/issue/BOE-326/[wallet]-update-the-disconnect-icon-to-an-updated-icon
We are upgrading to a slightly larger SVG image.
Storybook:
How has it been tested?