chore: Fix wallet hydration issue on next.js #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Zizzamia
reviewed
Aug 21, 2024
src/wallet/components/Wallet.tsx
Outdated
| const [isClient, setIsClient] = useState(false); | ||
|
|
||
| useEffect(() => { | ||
| setIsClient(true); |
There was a problem hiding this comment.
Let's try to solve this for 2~3 components at the same time.
As I see this being an issue for Identity components as well.
There was a problem hiding this comment.
i tested Identity in my app and it didn't seem to be an issue
Zizzamia
reviewed
Aug 21, 2024
| @@ -43,6 +43,17 @@ const WalletContent = ({ children }: WalletReact) => { | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
Let's make sure there is a changeset for this PR as well.
Zizzamia
reviewed
Aug 22, 2024
| @@ -26,6 +27,13 @@ export function Swap({ | |||
| }; | |||
| }, [children]); | |||
|
|
|||
| const isMounted = useIsMounted(); | |||
Zizzamia
reviewed
Aug 22, 2024
| @@ -0,0 +1,9 @@ | |||
| import { useEffect, useState } from 'react'; | |||
|
|
|||
| export function useIsMounted() { | |||
Zizzamia
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Following up on #1077
User reported receiving a hydration warning from their next.js app when integrating the
Walletcomponent which is likely because theWalletcomponent depends on client-specific data. The user is using pages routing and components in the pages/ directory are considered to be client-side by default, which, in this case, results in a hydration error.I am resolving this issue by returning
nullinWalletcomponent until the component mounts.Notes to reviewers
How has it been tested?