Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: moving getTokens under the API module #1146

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

Zizzamia
Copy link
Contributor

What changed? Why?

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 6:43am
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 6:43am
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 6:43am

isLoading: callStatus === 'PENDING',
isToastVisible,
lifeCycleStatus,
onSubmit: handleSubmit,
paymasterUrl: getPaymasterUrl(capabilities),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring this, in a way it's easier to test and reuse.

/**
* Note: exported as public Type
*/
export type GetTokensOptions = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving all getTokens code under the API module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant