feat: buildPayTransaction utilities in preparation for Pay button #1177
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@avidreder is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
avidreder
changed the title
|
Going forward for all APIs, let's have them live in the |
avidreder
force-pushed
the
pay-hydrate-charge
branch
from
98da364
to
80fceef
Compare
avidreder
force-pushed
the
pay-hydrate-charge
branch
from
80fceef
to
0f2ef02
Compare
avidreder
force-pushed
the
pay-hydrate-charge
branch
from
ae21793
to
b7724c6
Compare
avidreder
changed the title
| export type BuildPayTransactionParams = { | ||
| address: Address; // The address of the wallet paying | ||
| chainId: number; // The Chain ID of the payment Network (only Base is supported) | ||
| chargeId: string; // The ID of the Commerce Charge to be paid |
There was a problem hiding this comment.
Where can I read more about what's a Commerce Charge? Do we have live docs anywhere?
There was a problem hiding this comment.
This is probably the page I would point to: https://docs.cdp.coinbase.com/commerce-onchain/docs/crypto-payments for an overview of what a charge is (though not great info for this context, we'll have to update it).
Where do you think we should add this link in the code?
There was a problem hiding this comment.
Ok let's come back on this one, mostly i am questioning the word charge.
|
Great start!!! |
What changed? Why?
Notes to reviewers
How has it been tested?