feat: Add Swap Settings Slippage Title #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
changed the title
cpcramer
force-pushed
the
paul/swap-settings-title
branch
from
cd65860
to
f9740f3
Compare
Zizzamia
reviewed
Aug 30, 2024
| return ( | ||
| <h3 | ||
| className={cn( | ||
| 'mb-2 font-semibold text-base text-gray-950 leading-normal dark:text-gray-50', |
There was a problem hiding this comment.
dark color should be automatic, why is here custom?
Create this fork in the theme, make harder for developer to do custom themes at global level.
There was a problem hiding this comment.
Ah great point, I've removed text-gray-950 and dark:text-gray-50 and i've added --text-ock-foreground
cpcramer
force-pushed
the
paul/swap-settings-title
branch
from
23e6bce
to
d8e5021
Compare
Zizzamia
approved these changes
Aug 30, 2024
cpcramer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?