Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Swap Settings Slippage Layout #1196

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Conversation

cpcramer
Copy link
Contributor

What changed? Why?

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 5:09am
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 5:09am
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 5:09am

Copy link
Contributor

@Zizzamia Zizzamia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, general point for later is around better HTML semantic.

@Zizzamia Zizzamia merged commit 7623357 into main Sep 3, 2024
16 checks passed
@Zizzamia Zizzamia deleted the paul/swap-settings-layout branch September 3, 2024 16:48
@cpcramer
Copy link
Contributor Author

cpcramer commented Sep 3, 2024

Looks good, general point for later is around better HTML semantic.

I always default to using Divs, we be more deliberate around selecting the appropriate element!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants