-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Swap Settings Slippage Layout #1196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
force-pushed
the
paul/swap-settings-layout
branch
from
September 3, 2024 04:18
dee7eff
to
8ceed90
Compare
cpcramer
force-pushed
the
paul/swap-settings-layout
branch
from
September 3, 2024 04:20
8ceed90
to
08703cf
Compare
cpcramer
commented
Sep 3, 2024
cpcramer
changed the title
Paul/swap settings layout
feat: Swap Settings Slippage Layout
Sep 3, 2024
cpcramer
force-pushed
the
paul/swap-settings-layout
branch
from
September 3, 2024 05:03
4ce8456
to
64d09a0
Compare
Zizzamia
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, general point for later is around better HTML semantic.
I always default to using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?