prompt for wallet connection in TransactionButton
#1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xAlec
changed the title
TransactionButtonTransactionButton
0xAlec
changed the title
TransactionButtonTransactionButton
Zizzamia
reviewed
Sep 5, 2024
| const handleSubmit = useCallback(() => { | ||
| const handleSubmit = useCallback(async () => { | ||
| if (!address) { | ||
| await connectAsync({ connector: connectors[0] }); |
There was a problem hiding this comment.
Let's avoid create a branch of developer experience by adding a new way to solve the same problem we did with #1173 .
We want to make sure both experience re-use Wallet logic, and do not create internal branch on how the same problem can be solved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Transactionif missingaddressNotes to reviewers
How has it been tested?