chore: Update Swap Slippage v1 API for getting the Swap Quote #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
changed the title
0xAlec
approved these changes
Sep 12, 2024
alessey
reviewed
Sep 12, 2024
| apiParams = { | ||
| slippagePercentage: params.maxSlippage, | ||
| slippagePercentage: slippagePercentage, | ||
| ...apiParams, | ||
| }; |
There was a problem hiding this comment.
if we need this logic in a 3rd place, we should extract to a utility
alessey
approved these changes
Sep 12, 2024
abcrane123
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Adjust slippage for V1 API (aggregator). V1 expects slippage in tenths of a percent (e.g., 30 = 3%). This was implemented when creating the transaction but not when fetching the quote
Notes to reviewers
How has it been tested?