feat: add isSponsored prop for Swap
#1293
Conversation
0xAlec
force-pushed
the
alec/paymaster-swap
branch
from
bf91af4
to
00e0e7f
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/swap/components/Swap.tsx
Outdated
| @@ -21,6 +21,7 @@ export function Swap({ | |||
| onError, | |||
| onStatus, | |||
| onSuccess, | |||
| isSponsored, | |||
There was a problem hiding this comment.
could default to false here and not have to handle undefined
There was a problem hiding this comment.
I don't think we need special handling for undefined since it's falsey
There was a problem hiding this comment.
but I can add a default here
There was a problem hiding this comment.
added in latest diff
There was a problem hiding this comment.
I still like explicitly defining as false
src/swap/types.ts
Outdated
| @@ -267,6 +269,7 @@ export type SwapProviderReact = { | |||
| experimental: { | |||
| useAggregator: boolean; // Whether to use a DEX aggregator. (default: true) | |||
| }; | |||
| isSponsored?: boolean; // Whether the swap is sponsored. (default: false) | |||
There was a problem hiding this comment.
nit: starting the comment description with // An optional...
src/swap/types.ts
Outdated
| @@ -282,6 +285,7 @@ export type SwapReact = { | |||
| experimental?: { | |||
| useAggregator: boolean; // Whether to use a DEX aggregator. (default: true) | |||
| }; | |||
| isSponsored?: boolean; // Whether the swap is sponsored. (default: false) | |||
There was a problem hiding this comment.
nit: starting the comment description with // An optional...
src/swap/components/Swap.tsx
Outdated
| @@ -48,6 +49,7 @@ export function Swap({ | |||
| onError={onError} | |||
| onStatus={onStatus} | |||
| onSuccess={onSuccess} | |||
| isSponsored={isSponsored} | |||
There was a problem hiding this comment.
done - this was from when we called it sponsored
src/swap/components/Swap.tsx
Outdated
| @@ -21,6 +21,7 @@ export function Swap({ | |||
| onError, | |||
| onStatus, | |||
| onSuccess, | |||
| isSponsored = false, | |||
There was a problem hiding this comment.
done - this was from when we called it sponsored
What changed? Why?
isSponsoredpropNotes to reviewers
How has it been tested?