Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add SwapDefault component #1303

Merged
merged 6 commits into from
Oct 3, 2024
Merged

feat: add SwapDefault component #1303

merged 6 commits into from
Oct 3, 2024

Conversation

abcrane123
Copy link
Contributor

@abcrane123 abcrane123 commented Sep 25, 2024 •
edited
Loading

What changed? Why?

Screenshot 2024-09-25 at 11 39 17 AM

Screenshot 2024-09-25 at 12 18 09 PM

Screenshot 2024-09-25 at 11 40 22 AM

Notes to reviewers

How has it been tested?

@vercel Vercel
Copy link

vercel bot commented Sep 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 4:42pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 4:42pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 4:42pm

@abcrane123 abcrane123 marked this pull request as ready for review September 30, 2024 16:36
@abcrane123 abcrane123 changed the title feat: add swap default component feat: add SwapDefault component Sep 30, 2024
alessey
alessey approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@alessey alessey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems weird to be creating a wrapper component instead of just handling this in the docs. Our docs do need to be updated as well, there is no where you can just copy the full Swap component into your app.

@abcrane123 abcrane123 merged commit 1bf3c38 into main Oct 3, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessey alessey alessey approved these changes

@cpcramer cpcramer cpcramer approved these changes

@0xAlec 0xAlec 0xAlec approved these changes

Assignees
No one assigned
Labels
pkg: swap
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abcrane123 @alessey @cpcramer @0xAlec @alissacrane-cb