Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add embedded tweets to landing page #1312

Merged
merged 22 commits into from
Oct 1, 2024
Merged

Conversation

cpcramer
Copy link
Contributor

@cpcramer cpcramer commented Sep 26, 2024

What changed? Why?
Screenshot 2024-09-30 at 1 40 13 PM

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 8:41pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 8:41pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 8:41pm

@cpcramer
Copy link
Contributor Author

cpcramer commented Sep 26, 2024

Todo:

  1. Support light and dark mode.
  • To support light and dark mode, we need to update the data-theme attribute to data-theme: "dark" in dark mode or remove it in light mode.
  1. Polish styling to match Figma
    Custom styling is surprising difficult to apply 😅

Would love to sync on the above tomorrow and get your thoughts ^ @alessey 🙏

@cpcramer cpcramer merged commit 94b4b9d into main Oct 1, 2024
16 checks passed
@cpcramer cpcramer deleted the paul/add-embedded-tweets branch October 1, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

3 participants