feat: add fund button #1322
feat: add fund button #1322
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@steveviselli-cb is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -28,7 +28,7 @@ export const pressable = { | |||
| secondary: | |||
| 'cursor-pointer bg-ock-secondary active:bg-ock-secondary-active hover:bg-[var(--bg-ock-secondary-hover)]', | |||
| shadow: 'shadow-ock-default', | |||
| disabled: 'opacity-[0.38]', | |||
| disabled: 'opacity-[0.38] pointer-events-none', | |||
There was a problem hiding this comment.
Removes hover effects for disabled buttons. Confirmed with @mindapivessa.
| import type { WalletDropdownFundLinkReact } from '../types'; | ||
| import { WalletDropdownFundLinkButton } from './WalletDropdownFundLinkButton'; | ||
|
|
||
| export function WalletDropdownFundLink({ |
| @@ -13,7 +13,7 @@ export function Spinner({ className }: SpinnerReact) { | |||
| <div | |||
| className={cn( | |||
| 'animate-spin border-2 border-gray-200 border-t-3', | |||
| 'rounded-full border-t-blue-500 px-2.5 py-2.5', | |||
There was a problem hiding this comment.
Confirmed with @mindapivessa that this was the wrong color.
|
Nit - can we increase the sidebar width so smart wallet doesn't become 2 lines? @steveviselli-cb |
| /** | ||
| * Gets the appropriate popup dimensions for the given size and funding URL. | ||
| */ | ||
| export function getPopupSize( |
There was a problem hiding this comment.
since this is specific to funding, should this be getFundingPopupSize?
There was a problem hiding this comment.
@alessey Yeah sure I can do that! I figured that having it under /fund would make including fund in the name redundant, but probably better to be explicit.
There was a problem hiding this comment.
yea, that's true, my brain glossed over the /fund in the url when I first saw it.
@fakepixels that's just because I resized the browser window to be small for the video, it's not normally like that. |
| const overrideClassName = cn( | ||
| pressable.default, | ||
| // Disable hover effects if there is no funding URL | ||
| !fundingUrlToRender && 'pointer-events-none', |
There was a problem hiding this comment.
with this change, https://github.com/coinbase/onchainkit/pull/1322/files#diff-639b39dc7c8fa5ec11491e030f9add3c94620cae4c45a8e0a9412103659e41dfR31, this shouldn't be necessary right?
|
@steveviselli-cb will smart wallet be a part of a different PR? |
What changed? Why?
<FundButton />component integrated with Coinbase Onramp<FundButton />to PlaygroundPlayground demo with ProjectId is correctly configured:
Onramp.mov
Playground demo with ProjectId is NOT configured:
No.Project.ID.mov
Disabled wallet dropdown button treatment:
Correct spinner color i.e. not blue
Notes to reviewers
How has it been tested?