Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update OnchainKitProvider to fallback to CB verified schemaId #1575

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

cpcramer
Copy link
Contributor

@cpcramer cpcramer commented Nov 5, 2024

What changed? Why?
Default to use the COINBASE_VERIFIED_ACCOUNT_SCHEMA_ID in the OnchainKitProvider when the schemaID is missing. This is to prevent the DisplayBadge component from throwing an error.
Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 6:33pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 6:33pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 6:33pm

@cpcramer cpcramer changed the title chore: Update DisplayBadge to fallback to CB verified schemaId chore: Update OnchainKitProvider to fallback to CB verified schemaId Nov 5, 2024
@cpcramer cpcramer merged commit 106ecb4 into main Nov 5, 2024
16 checks passed
@cpcramer cpcramer deleted the paul/schemaID-optional branch November 5, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg: identity
Development

Successfully merging this pull request may close these issues.

4 participants