Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable deep linking to playground #1624

Merged
merged 69 commits into from
Nov 21, 2024
Merged

feat: enable deep linking to playground #1624

merged 69 commits into from
Nov 21, 2024

Conversation

dschlabach
Copy link
Contributor

@dschlabach dschlabach commented Nov 14, 2024

What changed? Why?
This PR adds deep linking capability to the playground. If a user has a bug or we'd like to share component configs internally, this will make that process a lot easier.

Also, refactored some logic in AppProvider to a new hook, useStateWithStorage, which handles setting state and localStorage and initializing with query params, in the case of a shared link.

Notes to reviewers

  • It would be helpful to get more eyes on this playground's preview link
  • The only param this doesn't support today is the paymasters state - unsure if it's ok to expose the paymasterUrl in params

How has it been tested?

  • Locally and in playground

@dschlabach dschlabach changed the base branch from main to dms/refactor-playground-1 November 14, 2024 20:41
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 2:35pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 2:35pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 2:35pm

@dschlabach dschlabach merged commit 81eb905 into main Nov 21, 2024
17 checks passed
@dschlabach dschlabach deleted the dms/linking branch November 21, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants