Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR adds support for validating V3 frame messages by adding an additional environment parameter to
getXmtpFrameMessage
that is passed into the updatedvalidateFramesPost
from@xmtp/frames-validator
.Notes to reviewers
To get the latest frames validator and types,
@xmtp/frames-validator
has been upgraded to^1.0.1
in bothpeerDependencies
anddevDependencies
.The return type of
getXmtpFrameMessage
has also been updated to a discriminated union for a better DX.For example:
How has it been tested?
Tests were not added or updated as they aren't necessary in this context. Validation of V3 Frames via
validateFramesPost
is tested in the@xmtp/frames-validator
package.