-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added toast animation #865
Conversation
@@ -28,8 +28,10 @@ export function useGetTransactionStatus() { | |||
// </a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abcrane123 can you remind me what's the story with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useWriteContracts
returns a transaction id that looks something like 0xf595f3f5111f88b30c668946d4430cf74326aadec59fe846…0000000000000000000000000000000000000000000014a34
. i asked connor how i can use this id to get the correct block explorer link for a pending transaction. i pass this id to useCallsStatus
to get the txn hash which i use to get the "view transaction" block explorer link but from the designs it looks like there is a way to get the explorer link with that transaction id.
@@ -62,6 +62,10 @@ export function useGetTransactionToast() { | |||
icon = <Spinner className="px-1.5 py-1.5" />; | |||
label = 'Transaction in progress'; | |||
} | |||
if (status === 'success') { | |||
icon = successSVG; | |||
label = 'Successful'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the SVGs let's move them into internal/svg/
folder
@@ -30,6 +30,21 @@ export default { | |||
screens: { | |||
md: '848px', | |||
}, | |||
keyframes: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is for test purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wasn't sure where i need to put this to get the fade in animation to work. noticed there is a top level tailwind.config.js
and this one. let me know if i should delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally those should come from OnchainKit, no?
What changed? Why?
Notes to reviewers
How has it been tested?