Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added toast animation #865

Merged
merged 10 commits into from
Jul 23, 2024
Merged

feat: added toast animation #865

merged 10 commits into from
Jul 23, 2024

Conversation

abcrane123
Copy link
Contributor

What changed? Why?

  • adjust toast animation
  • adjust toast message
  • export toast icon component
    Notes to reviewers

How has it been tested?

@github-actions github-actions bot added documentation Improvements or additions to documentation root labels Jul 23, 2024
@Zizzamia Zizzamia marked this pull request as ready for review July 23, 2024 19:24
@Zizzamia Zizzamia changed the title Add toast animation feat: added toast animation Jul 23, 2024
@@ -28,8 +28,10 @@ export function useGetTransactionStatus() {
// </a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abcrane123 can you remind me what's the story with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useWriteContracts returns a transaction id that looks something like 0xf595f3f5111f88b30c668946d4430cf74326aadec59fe846…0000000000000000000000000000000000000000000014a34. i asked connor how i can use this id to get the correct block explorer link for a pending transaction. i pass this id to useCallsStatus to get the txn hash which i use to get the "view transaction" block explorer link but from the designs it looks like there is a way to get the explorer link with that transaction id.

@@ -62,6 +62,10 @@ export function useGetTransactionToast() {
icon = <Spinner className="px-1.5 py-1.5" />;
label = 'Transaction in progress';
}
if (status === 'success') {
icon = successSVG;
label = 'Successful';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the SVGs let's move them into internal/svg/ folder

@@ -30,6 +30,21 @@ export default {
screens: {
md: '848px',
},
keyframes: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is for test purposes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wasn't sure where i need to put this to get the fade in animation to work. noticed there is a top level tailwind.config.js and this one. let me know if i should delete it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally those should come from OnchainKit, no?

@Zizzamia Zizzamia merged commit c30d877 into main Jul 23, 2024
12 checks passed
@Zizzamia Zizzamia deleted the alissa.crane/toast-polish branch July 23, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation root
Development

Successfully merging this pull request may close these issues.

2 participants