feat: close Wallet dropdown when clicking outside the component container #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
cpcramer
changed the title
cpcramer
force-pushed
the
paul/click-to-close-dropdown
branch
from
2d78fe0 to
bfd8921
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
changed the title
cpcramer
changed the title
cpcramer
changed the title
cpcramer
changed the title
cpcramer
force-pushed
the
paul/click-to-close-dropdown
branch
from
e2e8f5a to
3073007
Compare
cpcramer
force-pushed
the
paul/click-to-close-dropdown
branch
from
135e01a to
999d0fa
Compare
cpcramer
force-pushed
the
paul/click-to-close-dropdown
branch
from
999d0fa to
0c8801c
Compare
cpcramer
force-pushed
the
paul/click-to-close-dropdown
branch
from
0c8801c to
ecb628d
Compare
cpcramer
force-pushed
the
paul/click-to-close-dropdown
branch
from
ecb628d to
afc1742
Compare
cpcramer
changed the title
Zizzamia
reviewed
Aug 5, 2024
| expect(mockSetIsOpen).toHaveBeenCalledWith(false); | ||
| }); | ||
|
|
||
| it('should not close the wallet when clicking inside', () => { |
Zizzamia
reviewed
Aug 5, 2024
| }); | ||
|
|
||
| it('should remove event listener on unmount', () => { | ||
| const removeEventListenerSpy = vi.spyOn(document, 'removeEventListener'); |
Zizzamia
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Add Wallet container ref and click event listener. Close the wallet dropdown when the user clicks outside of the wallet + wallet dropdown container if the dropdown is active!
Functionality recording:
https://www.loom.com/share/e51e2e6b1838499b86dc257c1d543f76
Notes to reviewers
How has it been tested?