Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use types.Coin in CoinStorage #109

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Use types.Coin in CoinStorage #109

merged 1 commit into from
Aug 17, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Aug 17, 2020 •
edited
Loading

CoinStorage was using its own Coin type. This was unnecessary and made it difficult to import prefunded addresses.

Related PR: #105

WARNING

This PR introduces a new model to store coin data and will break any existing storage volumes.

Changes

  • Use *types.Coin in CoinStorage instead of own Coin type

@patrick-ogrady patrick-ogrady merged commit 310ca5b into master Aug 17, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/use-types-coin branch August 17, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliankoh juliankoh juliankoh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrick-ogrady @juliankoh