-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Automated Fund Return #135
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4752
💛 - Coveralls |
patrick-ogrady
requested review from
juliankoh,
cindyxkuang,
qiwu7 and
yfl92
September 16, 2020 15:46
cindyxkuang
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #119
Closes: #112
This PR adds support for automated fund return when reaching
check:construction
end conditions. This PR also includes updates to thebitcoin.json
configuration file that demonstrate how to use the newdry_run
feature to populate suggested fee.Changes
rosetta-sdk-go@v0.4.4
coordinator.ReturnFunds
after reaching exit conditionsethereum.json
to supportReturnFunds
bitcoin.json
to supportDryRun
bitcoin.json
to supportReturnFunds
bitcoin.json
to include assertion for feev0.5.2