Make error deserialization more resilient #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antstorm
reviewed
Dec 23, 2021
Contributor
antstorm
left a comment
antstorm
left a comment
There was a problem hiding this comment.
Thank you for the PR! A tiny comment, but otherwise looks good.
CC @drewhoskins-stripe in case you've got thoughts on this
| def initialize(message) | ||
| # This class simulates an error class that has bugs in its initialize method, or where | ||
| # the arg isn't a string. It raises TypeError (String can't be coerced into Integer) | ||
| 1 + message |
Contributor
There was a problem hiding this comment.
it would be clearer to just explicitly raise the error here
antstorm
approved these changes
Jan 10, 2022
Contributor
antstorm
left a comment
antstorm
left a comment
There was a problem hiding this comment.
Looks great, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#103 lets temporal-ruby respond gracefully when it can't construct the correct exception from serialized data. This PR makes that logic kick in for any type of deserialization failure, not just ArgumentError
Testing
I added a test to this unit:
bundle exec rspec ./spec/unit/lib/temporal/workflow/errors_spec.rbIntegration, to check for regressions: