Skip to content

Conversation

@aryak-stripe
Copy link
Contributor

Motivation

Exposing parent_workflow_id and parent_run_id in workflow executions will help with programming child workflows, and improve logging (since workflow metadata is appended to logs). This is mostly just plumbing from temporal's workflow started response.

Testing

I modified parent_workflow_spec to return the new metadata field from a child, and asserted that it was correct.

bundle exec rspec spec/
cd examples
./bin/worker
USE_ENCRYPTION=1 ./bin/worker
bundle exec rspec spec/integration

Copy link
Contributor

@antstorm antstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @aryak-stripe ! Thank you for adding this 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants