fix: Use Standard Interface for Metrics Tags #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@DeRauk @jeffschoner @calum-stripe Can someone kindly check this? |
Contributor
|
I don’t have permissions to merge changes in the repo. Only DeRauk can do that. However, looking at the linked issue, is it possible to add task queue tags to more of these sites? |
Contributor
Author
|
Added in few more places that I found feasible. I would really love to get a review and if possible merge to trunk. |
Convert keyword argument into hashes in order to fulfill Temporal::Metrics API contract obligations. Fixes: coinbase#90 Signed-off-by: Progyan Bhattacharya <bprogyan@gmail.com>
|
@DeRauk @jeffschoner @calum-stripe ^bump |
Contributor
|
@VAIBHAV7500 sorry for the (huge) delay. If you wouldn't mind resolving conflicts and tagging me again I'd be happy to merge. Edit: Tagging @0xTheProDev |
Contributor
Author
|
@DeRauk I have resolved the conflicts. Kindly take a look. |
DeRauk
approved these changes
Jan 5, 2024
Contributor
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert keyword argument into hashes in order to fulfill Temporal::Metrics API contract obligations.
Fixes: #90