Fix broken encryption specs, update Temporal API proto to 1.20 #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two problems were introduced when #224 was merged to master.
examples/spec/integration/converter_spec.rbwas not properly restoring the payload code configuration to default after changing it. This caused other workflows run afterward to encrypt their payloads on workflow start, even though there was no encryption set up in the worker. This in turn resulted in those workflows entering workflow task failure loops and being unable to complete.This fixes those problems:
Testing
All example specs now succeed. The spec with the mistake never failed, only corrupting state for running the others that followed.
Updated unit spec to check for the new, better error message: