-
Notifications
You must be signed in to change notification settings - Fork 107
Add keyword arguments support to Activity classes #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyword arguments support to Activity classes #255
Conversation
|
Hello everyone 👋 , here a small change that will allow the usage of keyword arguments in activities I'm open to discuss any changes and please let me know if you can see any possible issues because of my changes so I can try to fix them 🙌 |
|
I can also introduce the same change here https://github.com/coinbase/temporal-ruby/blob/master/lib/temporal/workflow.rb#L15-L16 |
5df9539 to
d059356
Compare
|
@santiagodoldan I missed merging this back in July 😬 . Do you mind rebasing and pushing again to get a new test run? I'd be happy to merge then. |
d059356 to
24343ba
Compare
|
@DeRauk Thanks 🙌 |
|
@santiagodoldan could you take a look at the failing tests? |
24343ba to
9d02ec8
Compare
|
@DeRauk It should be fine now 💯 |
coinbase#255 added support for keyword arguments in Temporal::Activity. However, there is a bug where if there are no keyword arguments and the last argument is a hash, then it will end up using that argument as the keyword argument instead of a positional argument.
…)" This reverts commit 95d62d2.
Revert "Add keyword arguments support to Activity classes (coinbase#255)"
No description provided.