Skip to content

Fix warnings #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeRauk merged 2 commits into from
Jan 16, 2024
Merged

Fix warnings #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abc7e78
Add base64 to gemspec for Ruby 3.4.0
jeffschoner Jan 16, 2024
0b2a8f0
Fix not to raise expectations to stop warning
jeffschoner Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/unit/lib/temporal/activity_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def execute(a, b:, c:)
it 'does not raise an ArgumentError' do
expect {
described_class.execute_in_context(context, input)
}.not_to raise_error(ArgumentError, 'wrong number of arguments (given 2, expected 1; required keywords: b, c)')
}.not_to raise_error
end

it 'returns #execute result' do
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/lib/temporal/workflow_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def execute(a, b:, c:)
it 'does not raise an ArgumentError' do
expect {
described_class.execute_in_context(ctx, input)
}.not_to raise_error(ArgumentError, 'wrong number of arguments (given 2, expected 1; required keywords: b, c)')
}.not_to raise_error
end
end
end
Expand Down
1 change: 1 addition & 0 deletions temporal.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ['lib']
spec.files = Dir["{lib,rbi}/**/*.*"] + %w(temporal.gemspec Gemfile LICENSE README.md)

spec.add_dependency 'base64'
spec.add_dependency 'grpc'
spec.add_dependency 'oj'

Expand Down