Move off Dry::Struct::Value before its removed from dry-struct
#293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@SalvatoreT Thank you for the PR! Could you please rebase onto master to get the test fix for CI? |
The current versions in the examples are pretty old.
The gem is warning that `Dry::Struct::Value` is finally going to be removed. ``` [dry-struct] Dry::Struct::Value is deprecated and will be removed in the next major version /Users/sal/Development/temporal-ruby/lib/temporal/concerns/typed.rb:35:in `generate_struct' ```
SalvatoreT
force-pushed
the
salvatoret/292/remove-Dry_Struct_Value-usage
branch
from
f5cc6f4 to
4854b59
Compare
Contributor
Author
|
Done! |
DeRauk
approved these changes
Apr 6, 2024
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the following warning before it becomes a bigger issue.
Closes #292