Skip to content

UTF safety #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antstorm merged 1 commit into from
Mar 5, 2021
Merged

UTF safety #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/temporal/client/serializer/payload.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def to_proto
payloads: [
Temporal::Api::Common::V1::Payload.new(
metadata: { 'encoding' => JSON_ENCODING },
data: JSON.serialize(object)
data: JSON.serialize(object).b
)
]
)
Expand Down
13 changes: 13 additions & 0 deletions spec/unit/lib/temporal/client/serializer/payload_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
require 'temporal/client/serializer/payload'

describe Temporal::Client::Serializer::Payload do
let(:hash) { { 'one' => 'one', two: :two, ':three' => '☻' } }

describe 'round trip' do
it 'safely handles non-ASCII encodable UTF characters' do
expect(
described_class.from_proto(described_class.new(hash).to_proto)
).to eq(hash)
end
end
end