-
Notifications
You must be signed in to change notification settings - Fork 107
Surface replay? on workflow contexts #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| end | ||
|
|
||
| def replay? | ||
| @state_manager.replay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @state_manager.replay? | |
| state_manager.replay? |
| nil | ||
| ) | ||
| end | ||
| describe '#replay' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| describe '#replay' do | |
| describe '#replay?' do |
| nil, | ||
| nil | ||
| ) | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline before describe
|
My only slight concern would be that people might think they can safely use |
|
After doing some more digging, I think we can get what we need without this change
|
…nal-with-start Update method signature in temporal test fixture
Adds a method to
Temporal::Workflow::ContextandTemporal::Testing::LocalWorkflowContextfor determining if a replay is occurring. This makes it possible to write a replay-aware custom logger or metrics emitter for other logging libraries besides the built-in Ruby logger. Specs forLocalWorkflowContextare extended to cover this new method and a new specs file is added for testingWorkflow::Context.