Support workflow termination. #49
Conversation
| workflow_execution: Temporal::Api::Common::V1::WorkflowExecution.new( | ||
| workflow_id: workflow_id, | ||
| run_id: run_id, | ||
| request_id: SecureRandom.uuid |
There was a problem hiding this comment.
This isn't a field on WorkflowExecution but on the higher ResetWorkflowExecutionRequest so I don't think this method would ever have worked.
There was a problem hiding this comment.
Also it's optional, so providing a random string that we don't return anyway doesn't feel useful.
lib/temporal.rb
Outdated
| response.run_id | ||
| end | ||
|
|
||
| def terminate_workflow(workflow, workflow_id:, **options) |
There was a problem hiding this comment.
Can you please make it look like coinbase/cadence-ruby#19?
There was a problem hiding this comment.
Do you mean the method signature? I think it should line up with start_workflow/schedule_workflow, and they use kwargs. terminate_workflow_execution takes namespace as an argument so I think ExecutionOptions should be used so that the Workflow classes namespace configuration is taken into account (as for start/schedule).
There was a problem hiding this comment.
Updated the method signature, although left namespace as nillable because it has a default value we can use.
…nal-with-start Update our FailWorkflowTask logic's call to ErrorHandler.handle
2 participants
No description provided.