[Refactor] Use local configuration instead of a global one #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calum-stripe
pushed a commit
to calum-stripe/temporal-ruby
that referenced
this pull request
Nov 10, 2022
…ner/remove-dupe-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sync of coinbase/cadence-ruby#41
To quote @anthonydmitriyev's description:
I'm working on a bigger change that will turn
CadenceTemporal into an initializable class rather than using a single global instance. This will allow connecting your app to multiple clusters (this is handy for easy migrating from oneCadenceTemporal cluster to another or more exotic solutions such as client-side sharding).This is the first step which makes configuration local, passed to all classes that are using it