Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Change yarn installation requirement to yarn classic #13

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Change yarn installation requirement to yarn classic #13

merged 2 commits into from
Mar 21, 2023

Conversation

yuga-cb
Copy link
Contributor

@yuga-cb yuga-cb commented Mar 21, 2023

Change yarn installation requirement to yarn classic

@yuga-cb
release 0.1.5
61add17
@yuga-cb
Merge to sync between internal repo and public repo
ec341bd 
* right/main:
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
@yuga-cb yuga-cb requested review from a user and jazz-cb March 21, 2023 23:27
@ghost
Copy link

ghost commented Mar 21, 2023 •
edited by ghost
Loading

Done.

However, now that i think about it, i understand how this readme could be a bit confusing, especially if you’re just blindly following the instructions.

You don’t actually need to install yarn unless you want to use it instead of npm. So labelling both node and yarn as Pre-requisites was confusing, esp in case of Leonard’s installation.

Omit Yarn as a pre-requisites. looking at other projects, they just don’t even specify node or yarn as a pre-requisites since most devs have it already. Instead if they don’t have it when they go to yarn add, they will get a prompt to install.

@yuga-cb
Copy link
Contributor Author

yuga-cb commented Mar 21, 2023

Yarn as a pre-requisites. looking at other projects, they just don’t even specify node or yarn as a pre-requisites since most devs have it already. Instead if they don’t hav

Acknowledged; however, the default react native tooling for react native libraries uses yarn, hence our dependency on it.

@yuga-cb yuga-cb merged commit 601dab8 into main Mar 21, 2023
@yuga-cb yuga-cb deleted the main-1679440919 branch March 21, 2023 23:45
jazz-cb added a commit that referenced this pull request Mar 23, 2023
@jazz-cb
Merge to sync between internal repo and public repo
1ac93a7 
* right/main:
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
jazz-cb added a commit that referenced this pull request Mar 23, 2023
@jazz-cb
Merge to sync between internal repo and public repo
cd6db85 
* right/main:
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
jazz-cb pushed a commit that referenced this pull request Mar 24, 2023
@yuga-cb
Change yarn installation requirement to yarn classic (#13)
3c7e238
jazz-cb added a commit that referenced this pull request Mar 29, 2023
@jazz-cb
Merge to sync between internal repo and public repo
0662eae 
* right/main:
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
jazz-cb added a commit that referenced this pull request Mar 29, 2023
@jazz-cb
Merge to sync between internal repo and public repo
3818577 
* right/main:
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
hyang74 added a commit that referenced this pull request Apr 14, 2023
@hyang74
Merge to sync between internal repo and public repo
6aeb8d9 
* right/main:
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
hyang74 added a commit that referenced this pull request Apr 18, 2023
@hyang74
Merge to sync between internal repo and public repo
33a5b3b 
* right/main:
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
jazz-cb added a commit to jazz-cb/waas-sdk-react-native that referenced this pull request May 22, 2023
@jazz-cb
Merge to sync between internal repo and public repo
628908e 
* right/main:
  Fix a known Xcode issue (coinbase#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (coinbase#22)
  Update ios binaries and release 0.1.6 (coinbase#17)
  Revert "Update ios binaries to fix regression" (coinbase#16)
  Update ios binaries to fix regression (coinbase#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (coinbase#14)
  Change yarn installation requirement to yarn classic (coinbase#13)
  [chore] Update registry link and docs (coinbase#12)
  [chore] Add publish workflow and fix typos (coinbase#11)
  Add android support (coinbase#10)
  add waas-sdk-react-native
jazz-cb added a commit that referenced this pull request May 22, 2023
@jazz-cb
Merge to sync between internal repo and public repo
663e634 
* right/main:
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
jazz-cb added a commit that referenced this pull request May 23, 2023
@jazz-cb
Merge to sync between internal repo and public repo
86ff994 
* right/main:
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
yuga-cb added a commit that referenced this pull request May 23, 2023
@yuga-cb
Merge to sync between internal repo and public repo
dbc7986 
* right/main:
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
jazz-cb added a commit that referenced this pull request May 31, 2023
@jazz-cb
Merge to sync between internal repo and public repo
3aab1d6 
* right/main:
  Release 1.0.1 of WaaS SDK (#34)
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
yuga-cb added a commit that referenced this pull request Jul 10, 2023
@yuga-cb
Merge to sync between internal repo and public repo
75f33d7 
* right/main:
  Release SDK 1.0.2 (#35)
  Release 1.0.1 of WaaS SDK (#34)
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
yuga-cb added a commit that referenced this pull request Jul 10, 2023
@yuga-cb
Merge to sync between internal repo and public repo
cd70ba1 
* right/main:
  Release SDK 1.0.2 (#35)
  Release 1.0.1 of WaaS SDK (#34)
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
yuga-cb added a commit that referenced this pull request Jul 10, 2023
@yuga-cb
Merge to sync between internal repo and public repo
756c2a7 
* right/main:
  Release SDK 1.0.2 (#35)
  Release 1.0.1 of WaaS SDK (#34)
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
yuga-cb added a commit that referenced this pull request Jul 10, 2023
@yuga-cb
Merge to sync between internal repo and public repo
a2ae0f6 
* right/main:
  Release SDK 1.0.2 (#35)
  Release 1.0.1 of WaaS SDK (#34)
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
yuga-cb added a commit that referenced this pull request Jul 10, 2023
@yuga-cb
Merge to sync between internal repo and public repo
8e83faa 
* right/main:
  Release SDK 1.0.2 (#35)
  Release 1.0.1 of WaaS SDK (#34)
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
yuga-cb added a commit to yuga-cb/waas-sdk-react-native that referenced this pull request Jul 11, 2023
@yuga-cb
Merge to sync between internal repo and public repo
5eecbb9 
* right/main:
  Release SDK 1.0.2 (coinbase#35)
  Release 1.0.1 of WaaS SDK (coinbase#34)
  Remove deprecated libraries for android (coinbase#33)
  Release 1.0.0 of WaaS SDK (coinbase#32)
  Fix a known Xcode issue (coinbase#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (coinbase#22)
  Update ios binaries and release 0.1.6 (coinbase#17)
  Revert "Update ios binaries to fix regression" (coinbase#16)
  Update ios binaries to fix regression (coinbase#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (coinbase#14)
  Change yarn installation requirement to yarn classic (coinbase#13)
  [chore] Update registry link and docs (coinbase#12)
  [chore] Add publish workflow and fix typos (coinbase#11)
  Add android support (coinbase#10)
  add waas-sdk-react-native
yuga-cb added a commit that referenced this pull request Jul 11, 2023
@yuga-cb
Merge to sync between internal repo and public repo
68c5dc7 
* right/main:
  Release SDK 1.0.2 (#35)
  Release 1.0.1 of WaaS SDK (#34)
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
yuga-cb added a commit that referenced this pull request Jul 12, 2023
@yuga-cb
Merge to sync between internal repo and public repo
7355439 
* right/main:
  WaaS SDK 1.0.3 (#44)
  Release SDK 1.0.2 (#35)
  Release 1.0.1 of WaaS SDK (#34)
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
yuga-cb added a commit that referenced this pull request Jul 13, 2023
@yuga-cb
Merge to sync between internal repo and public repo
230fe44 
* right/main:
  WaaS SDK 1.0.3 (#44)
  Release SDK 1.0.2 (#35)
  Release 1.0.1 of WaaS SDK (#34)
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
yuga-cb added a commit that referenced this pull request Jul 18, 2023
@yuga-cb
Merge to sync between internal repo and public repo
c53e87a 
* right/main:
  Update README (#46)
  WaaS SDK 1.0.4 (#45)
  WaaS SDK 1.0.3 (#44)
  Release SDK 1.0.2 (#35)
  Release 1.0.1 of WaaS SDK (#34)
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  [chore] Add publish workflow and fix typos (#11)
  Add android support (#10)
  add waas-sdk-react-native
jazz-cb added a commit that referenced this pull request Oct 4, 2023
@jazz-cb
Merge to sync between internal repo and public repo
c5ac261 
* right/main: (23 commits)
  Update version to 2.0.2 (#50)
  WaaS SDK 2.0.1 - Remove unused aar files (#49)
  WaaS SDK 2.0.1 (#48)
  Update README (#46)
  WaaS SDK 1.0.4 (#45)
  WaaS SDK 1.0.3 (#44)
  Release SDK 1.0.2 (#35)
  Release 1.0.1 of WaaS SDK (#34)
  Remove deprecated libraries for android (#33)
  Release 1.0.0 of WaaS SDK (#32)
  Fix a known Xcode issue (#25)
  Bump vm2 from 3.9.14 to 3.9.16 and release v1.0.7 (#22)
  Update ios binaries and release 0.1.6 (#17)
  Revert "Update ios binaries to fix regression" (#16)
  Update ios binaries to fix regression (#15)
  add ios xcframeworks
  add ios and android binaries
  [chore] Update binaries and release 0.1.5 (#14)
  Change yarn installation requirement to yarn classic (#13)
  [chore] Update registry link and docs (#12)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jazz-cb jazz-cb Awaiting requested review from jazz-cb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yuga-cb