-
Notifications
You must be signed in to change notification settings - Fork 970
Open
Description
Summary
Found TODO comments in the Python SDK middleware files suggesting a rename from output_schema to request_structure:
python/x402/src/x402/fastapi/middleware.py:111python/x402/src/x402/flask/middleware.py:195
# TODO: Rename output_schema to request_structureContext
After investigating, I found that:
- TypeScript SDK uses
outputSchemain v1 types (typescript/packages/core/src/types/v1/index.ts) - v2 seems to use a different approach with
extensionsinstead ofoutputSchema - Python SDK currently follows v1 patterns
Impact
This rename would be a breaking change affecting:
python/x402/src/x402/types.pypython/x402/src/x402/fastapi/middleware.pypython/x402/src/x402/flask/middleware.py- Multiple test files
Questions
- Should this rename be pursued as part of Python SDK v2 migration?
- Is there a planned timeline for Python SDK v2 alignment?
- Should we remove the TODO and keep current naming for v1 compatibility?
Happy to help with the implementation once the direction is clarified.
Metadata
Metadata
Assignees
Labels
No labels