fix(java): skip settlement for error responses (4xx/5xx) #723
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
|
@madisoncarter1234 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
bump |
phdargen
approved these changes
Dec 31, 2025
Contributor
|
Good catch @madisoncarter1234, please verify your commit and we can get this in |
Check response status before settlement in PaymentFilter. Skip settlement if handler returns 4xx/5xx to avoid charging users for failed requests. Matches Go/Python/TypeScript middleware behavior.
madisoncarter1234
force-pushed
the
fix/java-main-settlement-status-check
branch
from
903bec2 to
069f61b
Compare
Contributor
Author
ty! done, happy new year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds response status code check before settlement in Java PaymentFilter for the main branch.
Skips settlement if handler returns 4xx/5xx to prevent charging users for failed requests.
Changes
response.getStatus() >= 400check before callingfacilitator.settle()resp.getStatus()Related