svm: bump default compute unit limit to 8_000 #887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump the compute unit limit from 6500 to 8000.
It seems like the previous limit of 6500 might've been too strict and doesn't match the currently observed compute units on mainnet (6592).
This PR bumps it to 8000 to keep some buffer, since we are no longer estimating the compute unit usage ahead of time.
For context: the reason we are not estimating the compute unit usage ahead of time (in the client or facilitator) is that it saves an RPC call on each, making the user experience faster. Since the transaction is quite simple (simple
TransferChecked), a static limit vs 2 RPC calls seems like the right tradeoff.This may change again in the future after discussion on #828
Tests
All tests pass as before.
Checklist