Skip to content

Conversation

@notorious-d-e-v
Copy link
Contributor

Description

Bump the compute unit limit from 6500 to 8000.

It seems like the previous limit of 6500 might've been too strict and doesn't match the currently observed compute units on mainnet (6592).

This PR bumps it to 8000 to keep some buffer, since we are no longer estimating the compute unit usage ahead of time.

For context: the reason we are not estimating the compute unit usage ahead of time (in the client or facilitator) is that it saves an RPC call on each, making the user experience faster. Since the transaction is quite simple (simple TransferChecked), a static limit vs 2 RPC calls seems like the right tradeoff.

This may change again in the future after discussion on #828

Tests

All tests pass as before.

Checklist

  • I have formatted and linted my code
  • All new and existing tests pass
  • My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits

@cb-heimdall
Copy link

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link

vercel bot commented Dec 30, 2025

@notorious-d-e-v is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@phdargen
Copy link
Contributor

Thanks a lot @notorious-d-e-v, looks good to me!

Do you mind also updating this for the go implementation to keep them in sync?

DefaultComputeUnitLimit uint32 = 6500

@phdargen phdargen self-assigned this Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants